UI tests for reset password #31168

paurakhsharma · 2018-04-17T11:15:29Z

Description

UI test for testing reset password function

Related Issue

#31116

Motivation and Context

first step for acceptance tests for #31092 (review)

How Has This Been Tested?

run tests locally

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

CLAassistant · 2018-04-17T11:15:37Z

All committers have signed the CLA.

phil-davis

Great stuff - just 1 little comment.
The next challenge is how to extract the link from the email text and then browse to it and actually enter a new password.

phil-davis · 2018-04-17T11:33:31Z

tests/acceptance/features/bootstrap/WebUILoginContext.php

+	}
+
+	/**
+	 * @Then the a message with this text should be displayed on the webUI:


s/Then the a message/Then a message

codecov · 2018-04-18T03:41:42Z

Codecov Report

Merging #31168 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #31168   +/-   ##
=========================================
  Coverage     62.55%   62.55%           
  Complexity    18279    18279           
=========================================
  Files          1147     1147           
  Lines         68472    68472           
  Branches       1234     1234           
=========================================
  Hits          42831    42831           
  Misses        25280    25280           
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	`52.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`63.74% <ø> (ø)`	`18279 <ø> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba3d9e...a701040. Read the comment docs.

codecov · 2018-04-18T03:41:45Z

Codecov Report

Merging #31168 into master will increase coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #31168      +/-   ##
============================================
+ Coverage     62.26%   62.56%   +0.29%     
- Complexity    18279    18442     +163     
============================================
  Files          1147     1147              
  Lines         68474    68474              
  Branches       1234     1234              
============================================
+ Hits          42635    42839     +204     
+ Misses        25478    25274     -204     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	`52.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`63.75% <ø> (+0.33%)`	`18442 <ø> (+163)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share/Share.php	`67.14% <0%> (+0.06%)`	`508% <0%> (ø)`	⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php	`91.66% <0%> (+0.46%)`	`68% <0%> (ø)`	⬇️
lib/private/Files/Cache/Cache.php	`97.59% <0%> (+0.9%)`	`107% <0%> (ø)`	⬇️
lib/private/DB/MDB2SchemaWriter.php	`93.75% <0%> (+1.04%)`	`34% <0%> (ø)`	⬇️
lib/private/DB/MDB2SchemaManager.php	`91.22% <0%> (+1.75%)`	`17% <0%> (ø)`	⬇️
lib/private/AllConfig.php	`92% <0%> (+2.4%)`	`45% <0%> (ø)`	⬇️
lib/private/Repair/RepairInvalidShares.php	`97.26% <0%> (+2.73%)`	`17% <0%> (ø)`	⬇️
lib/private/Repair/RepairMismatchFileCachePath.php	`85.2% <0%> (+3.6%)`	`49% <0%> (ø)`	⬇️
lib/private/DB/ConnectionFactory.php	`82.89% <0%> (+3.94%)`	`21% <0%> (ø)`	⬇️
lib/private/DB/Adapter.php	`88.88% <0%> (+6.17%)`	`25% <0%> (ø)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5985706...2fcfa9e. Read the comment docs.

paurakhsharma · 2018-04-18T09:48:00Z

@phil-davis I have added some more tests, can you review it.

phil-davis

This looks really good. I just made some small comments about names of methods...

phil-davis · 2018-04-18T13:09:34Z

tests/acceptance/features/bootstrap/WebUILoginContext.php

+	 * 
+	 * @return void
+	 */
+	public function theAMessageWithThisTextShouldBeDisplayedOnTheWebui(PyStringNode $string) {


Not so important, but you can start this function name just with aMessageWith

phil-davis · 2018-04-18T13:16:18Z

tests/acceptance/features/lib/LoginPage.php

+	 * 
+	 * @return Page
+	 */
+	private function forgotPasswordField() {


The UI text has "reset" and the exception message below has "reset". So this method could be called resetPasswordField()
Otherwise there is sometimes "lost", "forgot" and "reset" for similar things.

phil-davis · 2018-04-18T13:17:41Z

tests/acceptance/features/webUILogin/resetPassword.feature

+Feature: send password reset email
+As a user
+I want to reset my password
+So that I can login my account with new password


So that I can login to my account again after forgetting the password

Thanks for the review and suggestions.
I will fix it right away.

phil-davis · 2018-04-19T05:01:37Z

@paurakhsharma please make a backport PR to stable10

paurakhsharma · 2018-04-19T06:08:53Z

backport in #31192

UI tests for reset password

lock · 2019-07-31T01:02:34Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

individual-it requested a review from phil-davis April 17, 2018 11:18

individual-it added 3 - To Review backport-request dev:acceptance-tests labels Apr 17, 2018

individual-it added this to the development milestone Apr 17, 2018

phil-davis reviewed Apr 17, 2018

View reviewed changes

individual-it mentioned this pull request Apr 18, 2018

Update lost password email to use HTML link #31092

Merged

9 tasks

individual-it added 2 - Developing and removed 3 - To Review labels Apr 18, 2018

paurakhsharma force-pushed the reset-password-test branch from 8d808f4 to 823d0f4 Compare April 18, 2018 09:46

paurakhsharma force-pushed the reset-password-test branch 2 times, most recently from bce86b2 to f9e47c3 Compare April 18, 2018 10:02

individual-it added 3 - To Review and removed 2 - Developing labels Apr 18, 2018

paurakhsharma force-pushed the reset-password-test branch from f9e47c3 to ca40b30 Compare April 18, 2018 11:09

phil-davis reviewed Apr 18, 2018

View reviewed changes

UI tests for reset password

2fcfa9e

paurakhsharma force-pushed the reset-password-test branch from ca40b30 to 2fcfa9e Compare April 19, 2018 03:51

phil-davis approved these changes Apr 19, 2018

View reviewed changes

phil-davis merged commit 8a52635 into owncloud:master Apr 19, 2018

paurakhsharma deleted the reset-password-test branch April 19, 2018 05:31

paurakhsharma mentioned this pull request Apr 19, 2018

[stable10] UI tests for reset password #31192

Closed

phil-davis removed the backport-request label Apr 19, 2018

phil-davis mentioned this pull request Apr 19, 2018

Acceptance tests for lost password email #31116

Closed

paurakhsharma pushed a commit to paurakhsharma/owncloud-core that referenced this pull request Apr 19, 2018

Merge pull request owncloud#31168 from paurakhsharma/reset-password-test

c0f90f4

UI tests for reset password

phil-davis mentioned this pull request Apr 20, 2018

[stable10] UI tests for reset password #31225

Merged

PVince81 modified the milestones: development, QA Jun 13, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI tests for reset password #31168

UI tests for reset password #31168

paurakhsharma commented Apr 17, 2018 •

edited by phil-davis

Loading

CLAassistant commented Apr 17, 2018 •

edited

Loading

phil-davis left a comment

phil-davis Apr 17, 2018

codecov bot commented Apr 18, 2018

codecov bot commented Apr 18, 2018 •

edited

Loading

paurakhsharma commented Apr 18, 2018

phil-davis left a comment

phil-davis Apr 18, 2018

phil-davis Apr 18, 2018

phil-davis Apr 18, 2018

paurakhsharma Apr 19, 2018

phil-davis commented Apr 19, 2018

paurakhsharma commented Apr 19, 2018

lock bot commented Jul 31, 2019

UI tests for reset password #31168

UI tests for reset password #31168

Conversation

paurakhsharma commented Apr 17, 2018 • edited by phil-davis Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

CLAassistant commented Apr 17, 2018 • edited Loading

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis Apr 17, 2018

Choose a reason for hiding this comment

codecov bot commented Apr 18, 2018

Codecov Report

codecov bot commented Apr 18, 2018 • edited Loading

Codecov Report

paurakhsharma commented Apr 18, 2018

phil-davis left a comment

Choose a reason for hiding this comment

phil-davis Apr 18, 2018

Choose a reason for hiding this comment

phil-davis Apr 18, 2018

Choose a reason for hiding this comment

phil-davis Apr 18, 2018

Choose a reason for hiding this comment

paurakhsharma Apr 19, 2018

Choose a reason for hiding this comment

phil-davis commented Apr 19, 2018

paurakhsharma commented Apr 19, 2018

lock bot commented Jul 31, 2019

paurakhsharma commented Apr 17, 2018 •

edited by phil-davis

Loading

CLAassistant commented Apr 17, 2018 •

edited

Loading

codecov bot commented Apr 18, 2018 •

edited

Loading